Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add x11 window type settings to viewport builder #4175

Merged
merged 9 commits into from
Mar 21, 2024
Merged

Add x11 window type settings to viewport builder #4175

merged 9 commits into from
Mar 21, 2024

Conversation

psethwick
Copy link
Contributor

@psethwick psethwick commented Mar 15, 2024 •
edited
Loading

Not sure about the api, currently I've mapped the whole XWindowType enum, but maybe there's something more sensible to do?

@psethwick psethwick marked this pull request as ready for review March 15, 2024 16:26
emilk
emilk reviewed Mar 17, 2024
View reviewed changes
crates/egui/src/viewport.rs Outdated Show resolved Hide resolved
emilk
emilk reviewed Mar 18, 2024
View reviewed changes
crates/egui/src/viewport.rs Outdated Show resolved Hide resolved
@emilk emilk added eframe Relates to epi and eframe egui labels Mar 18, 2024
@emilk emilk added the native-linux Problem specific to Linux label Mar 20, 2024
emilk
emilk reviewed Mar 20, 2024
View reviewed changes
crates/egui/src/viewport.rs Outdated Show resolved Hide resolved
emilk
emilk reviewed Mar 20, 2024
View reviewed changes
crates/egui/src/viewport.rs Outdated Show resolved Hide resolved
@emilk emilk changed the title add x11 window type settings to viewport builder Add x11 window type settings to viewport builder Mar 21, 2024
@emilk emilk merged commit 2c9c5f0 into emilk:master Mar 21, 2024
19 checks passed
@psethwick psethwick deleted the x11-windowtype branch March 21, 2024 12:06
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@psethwick @emilk @hacknus
Add x11 window type settings to viewport builder (emilk#4175)
72406ca 
Not sure about the api, currently I've mapped the whole XWindowType
enum, but maybe there's something more sensible to do?

* Closes <emilk#4150>

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
eframe Relates to epi and eframe egui native-linux Problem specific to Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose winit WindowType (X11 feature) in ViewportBuilder
2 participants
@psethwick @emilk